[fixed] Banned 'yahoo.com' not 'YAHOO.COM"'

[Steve Machol]

I have 'yahoo.com' as one of my banned email addresses. Yet someone has just registered successfully using 'YAHOO.COM'.

Is the banning feature case sensitive? This could be a big problem (yAhoo.com, YahOo.com, yaHOo.Com, etc.)

[eva2000]

really :eek: i have 12,500 free email providers listed not yet put into the ban and if i have to have an entry for each possible combination of casing that would be hugh :eek:

[Steve Machol]

That's what I thought too, but I definitely have 'yahoo.com' banned and a user just registered with 'YAHOO.COM'.

I know other users have tried to register using yahoo.com because they've written me complaining that their email address wasn't accepted.

[eva2000]

:eek:

[Steve Machol]

Here's the relevant section in my CP in case there are any doubters. I'll post the email next.

[Steve Machol]

Here's the new member email.

[eva2000]

well i had to add more capitalised emails for now but i disabled regos anyway for now

a few problem members :(

[Mike Sullivan]

Now it's case insensitive (it was using strstr() instead of stristr(), subtle difference).

[eva2000]

Originally posted by Ed Sullivan
Now it's case insensitive (it was using strstr() instead of stristr(), subtle difference). so no need to put

YAHOO.COM and yahoo.com or is there a fix for this ?

[Mike Sullivan]

Unless you make the code changes, you'll have to put every incarnation of a domain in.

But there will most likely be a bug fix release soon...

(Hmm... *kicks CD-ROM drive* Stop skipping! Argh!)

[Steve Machol]

Originally posted by Ed Sullivan
Now it's case insensitive (it was using strstr() instead of stristr(), subtle difference).

Was? :confused:

Are you saying this 'was' case sensitive but now it's not? If so, when did it change? And do you have any idea how this person was able to register? I don't know if the picture showed it but I definitely have banning options enabled.

[eva2000]

Originally posted by Ed Sullivan
Unless you make the code changes, you'll have to put every incarnation of a domain in.

But there will most likely be a bug fix release soon...

(Hmm... *kicks CD-ROM drive* Stop skipping! Argh!) great :) ... listeningg to music ?

[Mike Sullivan]

smachol -- was, as in I just changed it, approximately, 23 minutes and 45 seconds ago. :)

eva -- yeah, the new Tool album ("Lateralus"). It appears to have only been that song, but if it keeps happening I'm going to be pissed because I just bought the CD a week ago!

[Mas*Mind]

Originally posted by Ed Sullivan
eva -- yeah, the new Tool album ("Lateralus"). It appears to have only been that song, but if it keeps happening I'm going to be pissed because I just bought the CD a week ago!

Ed, I can talk with you :) I'm a big Tool fan, only couldn't get tickets for the concert in Holland of them :(

[eva2000]

Originally posted by Ed Sullivan
smachol -- was, as in I just changed it, approximately, 23 minutes and 45 seconds ago. :)

eva -- yeah, the new Tool album ("Lateralus"). It appears to have only been that song, but if it keeps happening I'm going to be pissed because I just bought the CD a week ago! know how you feel got the Gladiator DVD left it unwatched for 2 weeks then watched it and it hangs for 15 mins on one spot :(

[Steve Machol]

Originally posted by Ed Sullivan
smachol -- was, as in I just changed it, approximately, 23 minutes and 45 seconds ago. :)

Great - thanks! Can you tell me which script this is in and where to change it?

[Mike Sullivan]

eva--
My Matrix DVD did that... I think it's my POS DVD drive, though. (which, I should add is my audio CD drive now too... :))

Mas*Mind--
I'm just getting into Tool (literally -- I didn't like them until a week ago), so I'm not going to know much :) Now, if you wanna talk about the Smashing Pumpkins, that's a different story. LOL

But anyway, lets not take over this thread -- email me or start a new thread if you wanna talk :)

[Vinnie]

Can I get your list of free email service domains?

Or at least a managable subset of the most popular ones?

Is there a website that lists this?

[Steve Machol]

Originally posted by smachol


Great - thanks! Can you tell me which script this is in and where to change it?

Ed, could you please let me know which script I need to change to fix this? Thanks!

[Mike Sullivan]

register.php is the big one.

Lines 156 and 161, change strstr to stristr

[Steve Machol]

Made the change. Thanks again!

[eva2000]

Originally posted by Vinnie
Can I get your list of free email service domains?

Or at least a managable subset of the most popular ones?

Is there a website that lists this? well it's too big to attack in txt file 200kb hehe

i went to Edwin's site www.emailaddresses.com and www.fepg.net and also to www.another.com and www.everyone.net to see there lists :D

[eva2000]

Originally posted by Ed Sullivan
register.php is the big one.

Lines 156 and 161, change strstr to stristr there will be a 2.0.1 release right with some bug fixes ?

[Vinnie]

Would you please send it here?

info@freepeers.com

I'll import it into the MySQL database and add call some code from the register.php script to detect it - I don't think vBulletin will handle 200 kilobytes worth of banned email suffixes!! Besides it would be a nightmare to maintain.

I'll put this in an external php include file so it can be easily integrated into any distribution, as well as alleviate the problem with posting the entire file of vB source code to publish a mod.

There could also be a script to import new addresses so we can stay up to date as new free email services pop up.

I want to be very aggressive in filtering out these free email services! Please help!